fix(server): Generate library manifest from project source reader - #1629
Merged
Merged
Conversation
generateLibraryManifest matched the library resources feeding the manifest via project.getReader(). That reader reflects build output and workspace modifications, which conflicts with the versionInfo-middleware that relies on the _source_ reader and can't see any already generated manifest.json files. The versionInfo-middleware tasks the generateLibraryManifest to produce the missing manifest.json files, but the internal createManifestProcessor (which looks at the latest internal build result) refuses to produce the files since they already exist. This leads to missing information in the final sap-ui-version.json. Fix: Use project.getSourceReader(), which always reads the project's original sources regardless of any build result.
Fixes ocasional timeouts when running many tests in parallel
matz3
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateLibraryManifest matched the library resources feeding the manifest via project.getReader(). That reader reflects build output and workspace modifications, which conflicts with the versionInfo-middleware that relies on the source reader and can't see any already generated manifest.json files.
The versionInfo-middleware tasks the generateLibraryManifest to produce the missing manifest.json files, but the internal
createManifestProcessor (which looks at the latest internal build result) refuses to produce the files since they already exist. This leads to missing information in the final sap-ui-version.json.
Fix: Use project.getSourceReader(), which always reads the project's original sources regardless of any build result.