ci: Manually set up VS developer shell#628
Merged
Merged
Conversation
The ilammy/msvc-dev-cmd action has been unmaintained for a couple of years now, and GitHub has been showing warnings due to it using a deprecated Node version. Some forks exist, but in light of GHA supply chain attacks having become an almost weekly occurrence, it's probably safer to just set up the VS developer shell manually, which only takes a couple of lines of magic code. This is mostly copied from libass's workflow: https://github.com/libass/libass/blob/0.17.5/.github/workflows/meson.yml
Contributor
|
Why do you even need to do that? |
Member
Author
|
I didn't know about that flag, but I think I still prefer setting up the developer shell globally. For example, meson is not only called directly in the workflow file, but also from the installer setup script when building |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ilammy/msvc-dev-cmd action has been unmaintained for a couple of years now, and GitHub has been showing warnings due to it using a deprecated Node version.
Some forks exist, but in light of GHA supply chain attacks having become an almost weekly occurrence, it's probably safer to just set up the VS developer shell manually, which only takes a couple of lines of magic code.
This is mostly copied from libass's workflow:
https://github.com/libass/libass/blob/0.17.5/.github/workflows/meson.yml