break(meta) BREAK: Update coordEach for improved TypeScript inference - #3160
Merged
Merged
Conversation
mfedderly
force-pushed
the
mf/meta-rework
branch
from
September 7, 2026 15:19
7bf6fb4 to
825f0c0
Compare
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes several breaking API changes and improves test coverage and speed.
API Changes:
void | falsereturn type which lets you short-circuit the loop. This has always existed in the JavaScript path, but was not visible through the TypeScript typesAllGeoJSONto justGeoJSONfrom @type/geojson, which are equivalentPositioninstead ofnumber[], these are the same thing but Position comes from GeoJSON and is more specificGeometryCollectionsare officially unsupported now instead of working but behaving very strangely.Note on the nested GeometryCollections: its a little unfortunate that
GeoJSONtype quietly infers that you can have nested GeometryCollections. We could narrow the TypeScript types to enforce this, but then consumers would then be forced into doing their own type narrowing before calling coordEach, which is a little annoying as well.Implementation improvements:
varblock and push allocations into the areas where they are neededobj.typechecks, but this version benchmarks faster than factoring them out (macos / node 26)Benchmarks