Repository navigation
Updated gx to use pretty-cli's shipped types - #32067
Conversation
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin:test:acceptance --shard=1/3 |
✅ Succeeded | 6m 18s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 1m 55s | View ↗ |
nx run @tryghost/admin:test:acceptance --shard=2/3 |
✅ Succeeded | 5m 8s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 3m 48s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 2m 16s | View ↗ |
nx run @tryghost/koenig-lexical:test:acceptance... |
✅ Succeeded | 2m 25s | View ↗ |
nx run-many -t test:unit -p @internal/gx,@inter... |
✅ Succeeded | 40s | View ↗ |
nx run ghost:test:ci:unit |
✅ Succeeded | 1s | View ↗ |
Additional runs (16) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-10-19 15:20:15 UTC
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
WalkthroughThe workspace catalog updates Suggested reviewers: Priority: ⬇️ Low Change: Refactor Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: gx now uses types shipped by pretty-cli. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Type-Safe Boundaries | |
PASS. The PR updates @tryghost/pretty-cli types and removes local aliases, suppressions, and manual assertions from tools/gx CLI scripts. It introduces no any, unchecked as, @ts-ignore, or `… |
| New Files Are Typescript | |
The pull request adds no files. The changed-file inventory contains only modifications to existing YAML, lockfile, and TypeScript files. Therefore, it does not add a new .js, .jsx, .cjs, or .mjs sourc… |
| Description check | |
The pull request description directly matches the changes. It explains the upgrade to pretty-cli 3.4.0 and the removal of type suppressions, local command types, and parse-result assertions. |
Full details: Type-Safe Boundaries
-
Explanation
PASS. The PR updates
@tryghost/pretty-clitypes and removes local aliases, suppressions, and manual assertions fromtools/gxCLI scripts. It introduces noany, uncheckedas,@ts-ignore, or@ts-nocheck, and it does not duplicate a Zod-described shape. The check explicitly excludes scripts and config files.
Full details: New Files Are Typescript
-
Explanation
The pull request adds no files. The changed-file inventory contains only modifications to existing YAML, lockfile, and TypeScript files. Therefore, it does not add a new .js, .jsx, .cjs, or .mjs source file.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32067 +/- ##
==========================================
+ Coverage 84.99% 85.25% +0.25%
==========================================
Files 1383 1383
Lines 52106 52106
Branches 8971 8971
==========================================
+ Hits 44290 44423 +133
+ Misses 6708 6582 -126
+ Partials 1108 1101 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ref https://linear.app/ghost/issue/PLA-537/consolidate-repository-tooling-and-introduce-gx Use the published declarations so gx no longer needs missing-type suppressions or its own command and parse-result type workarounds.
728c20f to
92ec8de
Compare
ref https://linear.app/ghost/issue/PLA-537/consolidate-repository-tooling-and-introduce-gx
Use the declarations shipped in pretty-cli 3.4.0 so gx no longer needs missing-type suppressions, local command types or manual parse-result assertions. Follows framework#1059.
Validation:
pnpm --filter @internal/gx test: strict typecheck and all 94 command tests passed, including services commands.pnpm test:types: all 43 projects and their build dependencies passed.pnpm gx --helppassed.pnpm checkfailed on timeouts across several workspaces, including gx, and a Shade editor assertion. Isolated gx and App SDK reruns passed.