Skip to content

Fix sweep nonce non-determinism and disabled TLS hostname verification #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RobGanon wants to merge 1 commit into from
Closed

Fix sweep nonce non-determinism and disabled TLS hostname verification #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions electrumsv/gui/qt/sweep_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ def create_ssl_context(host: str) -> ssl.SSLContext:
if os.path.exists(pem_path):
try:
ctx.load_verify_locations(cafile=pem_path)
ctx.check_hostname = False
except Exception as e:
logger.warning("Failed to load host PEM %s: %s", pem_path, e)
return ctx
Expand Down Expand Up @@ -307,7 +306,8 @@ def sweep_single_privkey(
script_pubkey_bytes, value_sats = prevouts[i]
sighash = tx.signature_hash(i, value_sats, script_pubkey_bytes,
sighash=SigHash(SigHash.ALL | SigHash.FORKID))
der_sig = sk.sign_digest(sighash, sigencode=ecdsa.util.sigencode_der_canonize)
der_sig = sk.sign_digest_deterministic(
sighash, hashfunc=hashlib.sha256, sigencode=ecdsa.util.sigencode_der_canonize)
signature = der_sig + b"\x41" # SigHash.ALL|FORKID
txin.script_sig = Script(bytes([len(signature)]) + signature +
bytes([len(pubkey_bytes)]) + pubkey_bytes)
Expand Down