Repository navigation
feat: pick type and language from dropdowns when creating a page - #572
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
+ Coverage 83.59% 83.72% +0.12%
==========================================
Files 52 53 +1
Lines 2804 2838 +34
Branches 424 429 +5
==========================================
+ Hits 2344 2376 +32
Misses 350 350
- Partials 110 112 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44.
When creating a page, the single page-name box is replaced by a Type dropdown (Page, Template, Category, File), a Language dropdown (the wiki's existing languages), and a Name box. The server joins them into the page name. Editing or renaming an existing page still uses the single box.
New languages still can't be created from the wiki; the dropdown only lists existing ones, matching the existing validation.
Tests: the create-form tests now use the new fields. Tests for a missing or unknown language inject a fake option, so the server-side check is still covered. One new test creates a page in another language via the dropdown. black, flake8 and all 100 e2e tests pass locally. Checked by hand in Chromium at desktop and phone width.
🤖 Generated with Claude Code