fix(server): stop Claude probe stubs from outliving the test run - #57
Conversation
The probe aborts the SDK without awaiting the child, so a stub held open by an unconditional interval is reparented to init and survives until reboot, accumulating one stranded process per run. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview Instead of an unconditional keep-alive interval, those stubs now clear the interval and call Fork ledger 0025 documents the silent leak and notes the change is upstream-friendly test-harness hygiene with no product behavior impact. Reviewed by Cursor Bugbot for commit bed08e0. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: TrogonStack/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: TrogonStack/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Claude test fixtures now store their keep-alive intervals, clear them when stdin closes, and exit with code 0. This prevents child processes from remaining active after probe shutdown. ChangesClaude fixture lifecycle
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The ledger is the only place a divergence living entirely in test fixtures is visible, since a sync that reverts it fails nothing. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Summary by CodeRabbit