Skip to content

docs(fork): 0018 no longer claims T3 Code has no header or protocol names - #49

Merged
yordis merged 1 commit into
mainfrom
yordis/docs-otel-ledger-wording
Sep 17, 2026
Merged

yordis merged 1 commit into
mainfrom
yordis/docs-otel-ledger-wording

Conversation

@yordis

@yordis yordis commented Sep 17, 2026

Copy link
Copy Markdown
Member
  • The divergence entry was written before upstream gained its own OTLP header and protocol settings, so its Why now reads as false and hides what the divergence still does: accept the standard names alongside them.

…ames

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d741e262-144c-43d5-a3af-1a9e424651ec

📥 Commits

Reviewing files that changed from the base of the PR and between 4b5ff06 and cd5627f.

📒 Files selected for processing (1)
  • docs/fork/0018-the-standard-otel-variables-are-honored.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 17, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation-only wording fix with no runtime or configuration behavior changes.

Overview
Updates the Why section of fork divergence 0018 so it no longer says headers, resource attributes, and wire format had no configuration names at all.

It now states that the standard OTEL_* names for those settings were not wired through, while T3 Code’s own header and protocol env names exist upstream. The divergence is framed as still mattering because honoring the standard variables happens here, alongside those T3-specific names.

Reviewed by Cursor Bugbot for commit cd5627f. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Sep 17, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.2 KiB 13.5 KiB +393 B (+2.9%) 15.1 KiB
Codex Thread snapshot wire 6.9 KiB 7.1 KiB +165 B (+2.3%) 7.3 KiB
Codex Live turn WebSocket wire 6.2 KiB 6.5 KiB +228 B (+3.6%) 7.8 KiB
Codex Live turn WebSocket decoded 54.7 KiB 56.3 KiB +1.6 KiB (+2.9%) 66.4 KiB
Codex Live turn messages 8 10 +2 (+25.0%) 21
Claude Total thread wire 13.2 KiB 13.5 KiB +344 B (+2.6%) 15.1 KiB
Claude Thread snapshot wire 6.9 KiB 7.1 KiB +164 B (+2.3%) 7.3 KiB
Claude Live turn WebSocket wire 6.3 KiB 6.4 KiB +180 B (+2.8%) 7.8 KiB
Claude Live turn WebSocket decoded 55.5 KiB 57.0 KiB +1.5 KiB (+2.8%) 66.4 KiB
Claude Live turn messages 8 9 +1 (+12.5%) 21

Baseline: eb6fcb3 · PR result: cd5627f · Source CI: failure

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@yordis
yordis merged commit bd1c108 into main Sep 17, 2026
17 of 19 checks passed
@yordis
yordis deleted the yordis/docs-otel-ledger-wording branch September 17, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant