Skip to content

feat(indexing): support checkpoint progress writes#411

Merged
yordis merged 1 commit into
masterfrom
yordis/feat-index-checkpoint-writer
Jun 29, 2026
Merged

feat(indexing): support checkpoint progress writes#411
yordis merged 1 commit into
masterfrom
yordis/feat-index-checkpoint-writer

Conversation

@yordis

@yordis yordis commented Jun 28, 2026

Copy link
Copy Markdown
Member
  • Indexing processors need a shared progress boundary before lifecycle work can safely persist resume points.
  • Persisting checkpoint progress separately from event materialization keeps the next lifecycle slices smaller and easier to validate.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Jun 28, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Checkpoint persistence affects indexing resume correctness, but this PR only adds the writer and tests without wiring it into live indexing paths yet.

Overview
Introduces IndexCheckpointWriter, a small coordinator on top of IIndexCheckpointStore so indexing can buffer resume progress and flush it on demand instead of writing on every event.

Track(ResolvedEvent) records commit/prepare positions from the event’s original position (requires OriginalPosition; otherwise throws). Repeated tracks keep the latest pending checkpoint under a lock. Commit no-ops when nothing was tracked; otherwise writes the pending checkpoint and clears it only if no newer track arrived during the async write. Read forwards to the store.

Adds IndexCheckpointWriterTests with fakes covering delegation, track/commit semantics, validation, and cancellation propagation.

Reviewed by Cursor Bugbot for commit f2fa2c9. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yordis, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 49 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 17a54ebe-78e2-4cfb-9f20-7d7cb40c20b4

📥 Commits

Reviewing files that changed from the base of the PR and between 066ad50 and f2fa2c9.

📒 Files selected for processing (2)
  • src/EventStore.Core.XUnit.Tests/Services/Storage/Indexing/IndexCheckpointWriterTests.cs
  • src/EventStore.Core/Services/Storage/Indexing/IndexCheckpointWriter.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/feat-index-checkpoint-writer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis yordis merged commit f84c3f8 into master Jun 29, 2026
21 checks passed
@yordis yordis deleted the yordis/feat-index-checkpoint-writer branch June 29, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant