Skip to content

feat(indexing): support typed virtual stream routing#408

Merged
yordis merged 1 commit into
masterfrom
yordis/feat-index-virtual-reader
Jun 28, 2026
Merged

feat(indexing): support typed virtual stream routing#408
yordis merged 1 commit into
masterfrom
yordis/feat-index-virtual-reader

Conversation

@yordis

@yordis yordis commented Jun 28, 2026

Copy link
Copy Markdown
Member
  • Indexing-owned virtual streams need a typed routing boundary before concrete readers can safely share the read pipeline.
  • Centralizing stream matching keeps future reader implementations focused on indexing behavior instead of repeating identifier checks.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Jun 28, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
New abstract type and tests only; no changes to storage read paths or node wiring in this diff.

Overview
Introduces an abstract IndexVirtualStreamReader that implements IVirtualStreamReader for indexing-owned virtual streams. Each reader is bound to a typed IndexStreamId at construction (null rejected), exposes that id, and implements CanReadStream by comparing the candidate string to StreamId.Value so routing stays in one place. Forward/backward reads and last event/index position remain abstract for concrete indexing readers.

Adds IndexVirtualStreamReaderTests with a minimal test subclass covering constructor validation, StreamId exposure, and match/mismatch/null CanReadStream behavior.

Reviewed by Cursor Bugbot for commit 96ea9c9. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yordis, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 51 minutes and 48 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0274f6b4-3851-4e78-94e7-4c2a1981f958

📥 Commits

Reviewing files that changed from the base of the PR and between 0793925 and 96ea9c9.

📒 Files selected for processing (2)
  • src/EventStore.Core.XUnit.Tests/Services/Storage/Indexing/IndexVirtualStreamReaderTests.cs
  • src/EventStore.Core/Services/Storage/Indexing/IndexVirtualStreamReader.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/feat-index-virtual-reader

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis yordis merged commit cda6d10 into master Jun 28, 2026
21 checks passed
@yordis yordis deleted the yordis/feat-index-virtual-reader branch June 28, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant