Fix ns1 prefix collision between siri and ifopt namespaces - #1068
Fix ns1 prefix collision between siri and ifopt namespaces#1068sigfrido wants to merge 3 commits into
Conversation
netex_all_frames_framework.xsd and netex_all_frames_part5.xsd declared xmlns:ns1 for the ifopt namespace, while other transitively-included files (netex_ifopt_stopPlace_version.xsd, netex_ifopt_flexibleStopPlace_version.xsd, netex_siteFrame_version.xsd) already use ns1 for the siri namespace. Neither file references the ifopt namespace via the ns1 prefix in its body, so reverting the declaration to the standard `ifopt` prefix (used consistently in the other 9 files across the tree) is a safe, non-functional fix.
|
@sigfrido why not remove it, if it is not used? |
@skinkie you're right. I'm developing a tool for automated NeTEx/SIRI validation and schema tooling (will go OS soon); it includes a check that walks all Your comment made me realize that check should also flag unused namespace declarations, so I extended the tool and run it again. In the whole In this PR ( About this PR, what do you suggest? we could
Thanks |
|
@skinkie 778 unused namespace declarations across the NeTEx v2.0 schema tree netex_accessRightParameter_support.xsd : netex |
|
@sigfrido I don't mind that you clean them all, and limit the pull request to that. |
… also the ns1 (ifopt) prefix collision which first originated this change
|
Thanks! Can you do the dropping in the other file locations as well? So it is a single pull request cleaing up namespaces? @sigfrido would it be possible to discuss your NeTEx validation approach somewhere? |
…ma tree Extends the cleanup started for netex_all_frames_framework.xsd/netex_all_frames_part5.xsd to every other file: 772 unused xmlns:prefix declarations across 409 files, none of them referenced anywhere in their file (verified via ./model analyze-xsd's namespace-usage check in netex_tools). Only the default namespace and xmlns:xsd survive where nothing else was ever used; genuinely referenced prefixes are left untouched.
@skinkie added another commit with all the unused references dropped. I found these other problems (I don't know if anyone is using SOAP), shall I fix them in the same PR? Or a fresh PR?
Sure. I'm working for the Milan Metropolitan Agency for Public Transport - https://github.com/Agenzia-TPL The repo I'm working on is still private, but planned to go open ASAP. Meanwhile I'll drop you an email so we stay in touch. |
Separate PR please |
3 participants
netex_all_frames_framework.xsd and netex_all_frames_part5.xsd declared
xmlns:ns1 for the ifopt namespace, while other transitively-included files
(netex_ifopt_stopPlace_version.xsd, netex_ifopt_flexibleStopPlace_version.xsd,
netex_siteFrame_version.xsd) already use ns1 for the siri namespace. Neither
file references the ifopt namespace via the ns1 prefix in its body, so
reverting the declaration to the standard
ifoptprefix (used consistentlyin the other 9 files across the tree) is a safe, non-functional fix.
Confirmed still present on v2.1-wip as well.