Add GPT-OSS architecture adapter tests#1341
Merged
jlarson4 merged 1 commit intoMay 28, 2026
Merged
Conversation
Collaborator
|
Excellent test suite, thank you @RecreationalMath |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a unit test suite for
GPTOSSArchitectureAdapterundertests/unit/model_bridge/supported_architectures/, following the existing adapter-test pattern (modeled on the merged mixtral and olmoe suites). It needs no model downloads or real checkpoints: it uses tiny programmaticTransformerBridgeConfigobjects, plus small synthetic tensors and a fake attention module for the behavioral tests, so it runs on CPU in seconds.The suite (44 tests) covers:
eps_attr = "variance_epsilon").n_key_value_headsfallback.select_architecture_adapter.n_headswhile K/V surfacen_key_value_heads.setup_hook_compatibilityrotary-embedding wiring on a bridge model: a no-op whenbridge_modelis None or lacksrotary_emb, sets rotary on each block's attention bridge when present, skips blocks without attention, andsetup_no_processing_hooks(the backward-compat alias) produces the same wiring.Contributes to #1302 (GPT-OSS checkbox).
Type of change
Checklist: