Update baseof.html - #151
Open
wotclouduk wants to merge 1 commit into
Open
Conversation
Moved analytics code to head section as per Google instructions
1bl4z3r
added a commit
to 1bl4z3r/hermit-V2
that referenced
this pull request
Oct 21, 2023
pingz
pushed a commit
to pingz/hermit-V2
that referenced
this pull request
Apr 11, 2025
xuekepei
added a commit
to xuekepei/hermit
that referenced
this pull request
Aug 16, 2026
1. meta description (upstream issue Track3#119 — issue only, no PR) The theme never emitted <meta name="description">, so params.description went unused and Lighthouse reported "document does not have a meta description". baseof.html now falls back .Description -> .Summary -> .Site.Params.description. 2. Analytics into head (upstream PR Track3#151) Loads earlier, losing fewer hits from visitors who leave quickly. 3. code-copy with table layout (upstream PR Track3#137) With markup.highlight.lineNos enabled chroma emits a <table> and copying grabs the line numbers too; select only the code cell in that case. 4. Admonition shortcodes (upstream PR Track3#130) Adds note / tip / warning. Four defects in the original PR are fixed: - all three shared one blue border colour, making them indistinguishable -> coloured per semantic - content background used $highlight-grey, ~2.5:1 against $text, below the WCAG AA 4.5:1 minimum -> $light-grey, ~6.5:1 - vertical margins sat on .admonition-content so the left border did not enclose the content -> moved to the container - .Inner abutted the <div>, so CommonMark's HTML block rule skipped inline Markdown parsing and bold/links inside the box stayed literal -> separated by blank lines Also drops $_hugo_config, deprecated since Hugo 0.55. Verified on Hugo v0.164.0+extended: builds with no warnings, all three colours compile, and Markdown inside the boxes renders. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved analytics code to head section as per Google instructions