Frontend review fixes: contrast, landmarks, skip link, motion - #15
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: the frontend review found the primary CTA unreadable in dark mode and several a11y gaps.
Value: WCAG AA contrast in both themes, landmarks and skip link on every page, keyboard-reachable tooltip, reduced-motion respected by JS scrolls.
Contrast (before -> after):
Also: skip link, main landmark on ThankYou/NotFound, scroll helper honoring reduced motion, split ScrollToTop effects, hover tooltip also on focus, nav aria-labels, theme toggle name, trailingSlash false, docs refreshed (stale reduced-motion/CSP claims, em dashes, design-system tokens).
Left: lazy routes, Tailwind direction, tests/axe, shell OG, robots, vercel.live, Bun pin (suggestions needing a decision).
ToDo: