Updated flake.nix and added to gitignore - #9
Closed
PyricRL wants to merge 7 commits into
Closed
Conversation
| git tag -a v0.1.0 -m "v0.1.0" | ||
| ''; | ||
|
|
||
| installPhase = '' |
Owner
There was a problem hiding this comment.
It seems that the flake still only considers oshot being built without plugins support. I don't use nixOS so idk, but is it possible to pass an argument to wether to build or not with plugins support? Thus install the shared libraries too?
Author
There was a problem hiding this comment.
Yes, nix has support for different branches natively, but installing shared libraries has to be manually configured. I would have to do a bit more testing to make sure it works for that.
| { | ||
| oshot = pkgs.stdenv.mkDerivation { | ||
| pname = "oshot"; | ||
| version = "0.1.0"; |
Owner
There was a problem hiding this comment.
We are at version v0.5.0-rc1. Is this related to oshot's package version?
Author
There was a problem hiding this comment.
Yes, this is related to the oshot package version. Forgot to adjust it.
Shootout @PyricRL on GitHub for the new oshot look :)
GDK queues the dialog's surface destroy/unmap request rather than sending it immediately. Since oshot never runs a GTK main loop after create_dialog() returns, that request stayed unflushed and Wayland compositors kept rendering the last frame until the whole process exited, even though the dialog had already been dismissed. Pump gtk_events_pending()/gtk_main_iteration() right after nvd_free_object() to force the flush.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated flake.nix and flake.lock to support newest updates.