Repository navigation
Conversation
The keyring, key store, key hierarchy and migration from #326 (9131d24), rebased onto main: the migration is renamed to m20261107_000000_at_rest_keys and appended after main's newest migration; lockfiles refreshed. New: AtRestKeyring::open_with_previous_root. When the stored ARK rows do not open under the current root but do under the previous one, every generation is re-sealed under the current root, in the database and the mirror. Chains, DEK wraps and object names are unchanged, so a root change rewrites one row per generation and no data. Retirement markers made under the previous root still count.
samgbafa
force-pushed
the
skgbafa/tc-887-r2-keyring
branch
from
November 7, 2026 23:38
c12c6e9 to
e8b6cd9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TC-887. Second PR of the refreshed at-rest stack (base: #513). Replaces #326.
What
tinycloud-core/src/at_rest/{hierarchy,keyring,store}.rs, theat_rest_key/at_rest_escrow/space_data_keymodels and their migration, unchanged from feat(TC-887): at-rest keyring, key store and migration #326 at9131d24(reviewed and approved there).m20261107_000000_at_rest_keysand appended after main's newest migration (m20261026_000000), so the list stays in name order. It has never been released.tinycloud-coregainslru,parking_lotand the escrow crate. The root,test/m1-realdata-e2eandtest/w5-policy-runtime-node-e2elockfiles are refreshed. The w5 lock also picks up main's currenttinycloud-nodeversion.AtRestKeyring::open_with_previous_root. If the stored ARK rows don't open under the current root but do open under the previous one, every generation is re-sealed under the current root, in the database and in the mirror, and the keys unlock.Not here
Verification
cargo test --locked -p tinycloud-core at_rest: all pass, including the newa_previous_root_reseals_every_generation_under_the_new_rootanda_previous_root_that_opens_nothing_leaves_the_keys_locked.cargo clippy --locked -p tinycloud-core --all-targetswith-Dwarnings, andcargo fmt --all -- --check: clean.