Repository navigation
fix(sql): preserve unacked batch messages when ack deadline expires - #63
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes ThreeDotsLabs/watermill#700.
When using queue offsets adapters (such as PostgreSQLQueueOffsetsAdapter and MySQLQueueOffsetsAdapter), Subscriber.query fetches a batch of rows and iterates through them. If an earlier message in the batch misses its AckDeadline, Subscriber.query breaks the iteration loop. Previously, it passed the entire slice of selected rows (Rows: messageRows) to AckMessageQuery. Because queue adapters delete or mark as acknowledged every row present in params.Rows, all subsequent unprocessed rows in the batch, along with the timed-out message, were deleted or marked as acknowledged.
Details
Alternative approaches considered (if applicable)
Filtering rows by offset inside individual offsets adapters was considered, but passing only acknowledged rows directly from Subscriber.query solves the problem at the caller level for all queue adapters and prevents unnecessary row allocations downstream.
Checklist