feat: Add Docker-backed executor with network-none and read-only root - #9
Open
ThomasHartDev wants to merge 2 commits into
Open
feat: Add Docker-backed executor with network-none and read-only root#9ThomasHartDev wants to merge 2 commits into
ThomasHartDev wants to merge 2 commits into
Conversation
runInDocker implements the same RunResult contract as run/runInWorker inside a disposable container: no network, read-only rootfs, dropped caps, and no host env. Named containers are force-removed on abort so guests cannot orphan.
JSON.stringify mangled NaN/Infinity/Map/TypedArray while still returning status ok. Guest results now use a framed v8.serialize channel (AIRLOCK1:base64) so structured-clone types match the worker contract; non-cloneable values fail closed. Split docker live tests into contract, fidelity, OOM, and isolation suites; document the transport in the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
runInDockerbehind the sameRunResultcontract asrunandrunInWorker. Each run is a disposable container with--network=none, a read-only rootfs (tmpfs/tmp), dropped capabilities, non-root uid, and no host env. Abort and timeout force-remove the named container before killing the CLI so guests cannot orphan.Return-value transport: grants enter as JSON (functions/symbols/bigints refused before spawn). Results leave the guest via framed
node:v8serialize (AIRLOCK1:<base64>), host-deserialized with structured clone fidelity for NaN, Infinity, Map, Set, Date, and TypedArray — matchingrunInWorker. Non-cloneable values fail closed asstatus: "error", never a corruptedok.Live tests cover the contract, value fidelity, cgroup OOM (
maxMemoryMb), and host-env / outbound-net / write / path escape attempts; they skip cleanly when Docker is unavailable.