Repository navigation
fix(upstreams): undo layout squeezed only to avoid a scrollbar - #321
Merged
Merged
Conversation
#319 and #320 made every step of the upstream dialog fit 1100x720 without a scrollbar, including the steps with many settings. That rule was meant for steps with few options and a lot of empty space. Steps with many settings may scroll: the dialog keeps its fixed height and its body scrolls. Options crammed into columns, descriptions dropped and results moved into hovers only to save a few rows go back to their natural form. The approved redesign stays (service tiles and search, auth rows, Advanced settings collapsed unless set, Check on Next when creating, sign-in cards, account summary rows, the import host note). - Edit dialog: Check connection is back in the Connection section body, with the full result and the balance below it, not in the footer with the details in a hover. - Advanced settings, expanded: headers full width, then Forward client identity with its description, then the short fields two per row (proxy unavailable, concurrency limit with its description, and the balance source for Custom as a normal labelled field). - Connection: the base URL is full width again, protocol and region share the next row; AWS access keys and OAuth go back to two columns with the session token and access token on their own rows; the English "Auto-detect (not detected, forwarded as is)" that was shortened for the narrow protocol column is back. Spacing back to the form's gap-4. - Descriptions restored, as worded before: base URL, headers (${NAME}), session token, OAuth access token, and the egress note on the ChatGPT account page; also the Z.ai key-storage notice and the full device code warning, which had been cut to fit one line. - ChatGPT account page: name and egress in two columns with the concurrency limit below, usage limits above reset credits, gap-5. - Import link: the dialog no longer grows by the note's height; the note takes its space from the body, and long host names wrap instead of being cut off. - Billing: the price sheet rows keep their normal padding, and the import link's new-sheet row wraps its detail and its error instead of truncating them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The user approved that row in the design; a step with few fields does not need the extra line, and the base URL hint still sits under the address. The undetected label stays short for the narrower column. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#319 and #320 made every step of the New/Edit upstream dialog fit the default 1100×720 window with no scrollbar, including the steps with many settings. That rule is meant for steps with few options and a lot of empty space, which should be tidied to fit. Steps with many settings may scroll: the dialog keeps its fixed height and its body scrolls when the content is taller. This PR puts back the natural layout wherever options were crammed into columns, descriptions dropped, or results moved into hovers only to avoid a scrollbar.
The approved redesign is unchanged: 4-column service tiles with the search beside the steps, auth rows per service, Advanced settings collapsed by default and expanded when something in it is set, Check on Next when creating (result row on Models), the two sign-in method cards, the Z.ai method | site row, the account summary rows and the import host note.
Reverted squeezes
${变量名}reads an environment variable), session token (only temporary credentials have one), OAuth access token (used only to check before saving), egress on the ChatGPT account page. The Z.ai "requests go to …" line and the name hint stay removed.noteHeightstyle override and the ResizeObserver removed); the note takes its space from the body, which scrolls if needed. Long host names wrap instead of being truncated.UpstreamDialog,ModelsSection,ManualModelInputandBillingSectionnow state the corrected rule.Checked and kept
Verification
pnpm typecheck,pnpm test(108 files, 1192 tests).🤖 Generated with Claude Code