Repository navigation
Scan alerts: a finding that only moved to another line is not reported again - #296
Merged
Merged
Conversation
…d again Editing ~/.codex/config.toml (a line added above, a model changed) moved every remote MCP server below it, and the watcher reported all of them again as new: a finding was recognised by path, rule, line and the line's text. Each finding now carries a subject that does not depend on where it is in the file: the server's name and address for a remote MCP server, the matched text for a rule, the line's text for hidden characters, the skill's name for over-broad tools. The watcher compares path, rule and subject, counted, so a second identical finding is still new. The seen set keeps only hashes, so it holds nothing from the files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing
~/.codex/config.toml(adding a line above, changing the model) moved every remote MCP server below it, and the client-config watcher reported all of them again as new, because a finding was recognised by path, rule, line number and the line's text.tw-scan: eachFindingcarries asubjectthat does not depend on its position — the server's name and address forremote-mcp, the matched text for a rule hit, the line's text for hidden characters, the skill's name forover-broad-tools.Seen::diffcompares path + rule + subject, counted: a finding that only moved is not new; a second identical one, or a different server under the same rule, is. The seen set stores only hashes, so it keeps nothing from the files.Checks:
cargo fmt --check,cargo clippy --all-targets -D warnings,cargo test(900 passed).🤖 Generated with Claude Code