VTA: home-wifi detection via iw when iwgetid is missing; installer adds audio group - #74
Merged
Merged
Conversation
…group Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found setting up voice on the VTA-439 (27 Sep):
trips.current_ssid()only usediwgetid(wireless-tools). The VTA had no wireless-tools, so every home check read False: the dash asked for a password on the home wifi (wifi routeris in its home_ssids) and trip tracking could not see home. Now falls back toiw dev <wireless if> link, which the VTA has and which reportsSSID: wifi router.install.shnever added the user to theaudiogroup. Pi OS does that for the first user; Ubuntu does not, and the listener then cannot open the USB speakerphone. Nowusermod -aG audiowhen missing. (install.sh already installs alsa-utils and wireless-tools; the VTA was evidently not set up through it.)Tests: new tests/test_current_ssid.py (4; fail on main), 176/176.
🤖 Generated with Claude Code