build(deps): track and enforce pnpm lockfile#2010
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDependency versions and Sharp typing are updated. GitHub Actions workflows now use ChangesDependency and CI reproducibility
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/main/scripts/pnpmInstallWorkflow.test.ts`:
- Around line 18-23: Rename the workflowInstallCounts constant to
WORKFLOW_INSTALL_COUNTS and update its reference at the usage site in the test.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 50838901-86af-48f9-9bfc-a069a3453cfc
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (10)
.github/workflows/build.yml.github/workflows/prcheck.yml.github/workflows/release.yml.github/workflows/windows-arm64-e2e.yml.gitignoredocs/architecture/pr-check-quality-gates/spec.mdpackage.jsonsrc/main/ocr/imagePreprocessor.tstest/main/scripts/pnpmInstallWorkflow.test.tstest/main/scripts/prcheckWorkflow.test.ts
💤 Files with no reviewable changes (1)
- .gitignore
Summary
pnpm-lock.yamlgenerated with Node.js 24.14.1 and pnpm 10.33.4.@lingual/i18n-check.pnpm install --frozen-lockfilein PR checks, platform builds, releases, and Windows ARM64 E2E.Motivation
pnpm-lock.yamlwas previously ignored, so identical commits could resolve different direct and transitive dependency versions over time.Tracking the lockfile and enforcing frozen installs makes dependency resolution reproducible for the same platform and fixed Node.js/pnpm versions. CI now fails immediately when a manifest change is not accompanied by the corresponding lockfile update.
This guarantees reproducible dependency inputs, but does not claim byte-for-byte identical installers across operating systems, signing environments, timestamps, or dynamic Provider/ACP data refreshes.
Compatibility and security notes
pnpm audit --audit-level highpasses.@hono/node-server@1.19.14, introduced through@modelcontextprotocol/sdk. The patched Hono version requires an incompatible major upgrade, and DeepChat does not directly use the affected static-file middleware, so no forced override was added.Summary by CodeRabbit
Dependency Updates
Reliability Improvements
pnpm install --frozen-lockfileto ensure lockfile consistency across builds, tests, releases, and platform workflows..gitignoreto stop ignoringpnpm-lock.yaml.Bug Fixes
Tests