perf(i18n): lazy-load renderer locales#2003
Merged
Merged
Conversation
Load only the active locale and English fallback before mounting renderer apps. Guard runtime language switches against stale async loads and keep build-refreshed provider metadata current.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (16)
📝 WalkthroughWalkthroughChangesRenderer i18n lazy loading
ACP registry releases
Model catalog metadata
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant RendererEntry
participant createRendererI18n
participant loadLocaleMessages
participant VueI18n
RendererEntry->>createRendererI18n: fetch language state
createRendererI18n->>loadLocaleMessages: load en-US and requested locale
createRendererI18n->>VueI18n: create i18n with loaded messages
createRendererI18n-->>RendererEntry: return i18n and language state
RendererEntry->>VueI18n: mount application
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zhangmo8
added a commit
that referenced
this pull request
Jul 20, 2026
…e-optimization Resolve language/i18n conflicts to preserve this PR's scope-boundary race fixes (languageInitialization promise cache, listener-before-snapshot registration, documentAppearance abstraction) alongside the lazy renderer locale loading (#2003) and dashboard CPU reduction (#2004) perf wins from dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
en-USfallback before mountStartup Flow
BEFORE
AFTER
Bundle Result
4.25 MB->917,504 B1.33 MB->300,498 B157-264 KBeach)Validation
pnpm run formatpnpm run i18npnpm run lintpnpm run build(includes node/web typecheck)MemorySettingssuite: 11/11 passedorigin/devApp.startup.test.tsmock returningundefinedfor the Promise-basedinitAppStores; the remaining failure was a 10s full-suite concurrency timeout and passes in isolation.Summary by CodeRabbit
New Features
Bug Fixes