Repository navigation
Conversation
Saving the same result name twice raises because the result directory is created without allowing it to exist already.
The result directory was created with mkdir that rejects an existing path. A second save of the same result name then failed. Create the directory only when it is missing and replace the files in place.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finish_search created the result directory with a mkdir that rejects an existing path, so a second save of the same result name failed.
The mkdir now accepts an existing directory. This is the finish_search call, which #802 does not touch. The process search guide and a newsfragment record the change.
tests/test_explorer_result_dir.py::test_saving_a_result_twice_keeps_the_filesfails on develop at d243519 and passes on this branch.