Fix deploy failure: make gen-manticore-docs.sh executable (#3)#4
Open
p0dalirius wants to merge 1 commit into
Open
Fix deploy failure: make gen-manticore-docs.sh executable (#3)#4p0dalirius wants to merge 1 commit into
p0dalirius wants to merge 1 commit into
Conversation
Set the git executable bit on scripts/gen-manticore-docs.sh (was 100644) and invoke it via bash in the deploy workflow so the generation step no longer exits 126 with Permission denied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #3
Root Cause
scripts/gen-manticore-docs.shwas committed with mode100644(non-executable). The deploy workflow invoked it directly (run: scripts/gen-manticore-docs.sh), which requires the executable bit, so the "Generate Manticore API docs" step exited 126 withPermission deniedand the deploy failed before the Hugo build.Fix Description
Two complementary changes:
scripts/gen-manticore-docs.sh(100644->100755).bash scripts/gen-manticore-docs.shindeploy.yml, so the step no longer depends on the file's mode and cannot regress this way again.How Verified
git ls-tree HEAD scripts/gen-manticore-docs.shnow reports mode100755.bash <script>, which executes regardless of the executable bit (reproduced locally:bash scripts/gen-manticore-docs.sh v1.1.5runs and generates the docs tree).Test Coverage
Scope of Change
.github/workflows/deploy.yml,scripts/gen-manticore-docs.sh(mode only).Risk and Rollout
Minimal and local to the deploy step. Safe to merge directly.