Skip to content

Improve pyramid validation messages and add tests - #7686

Open
Jkhaleed wants to merge 1 commit into
TheAlgorithms:masterfrom
Jkhaleed:lab6-code-review
Open

Jkhaleed wants to merge 1 commit into
TheAlgorithms:masterfrom
Jkhaleed:lab6-code-review

Conversation

@Jkhaleed

Copy link
Copy Markdown
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new algorithms include a corresponding test class that validates their functionality.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.25%. Comparing base (2319794) to head (f65bda3).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7686      +/-   ##
============================================
+ Coverage     82.22%   82.25%   +0.02%     
- Complexity     8403     8407       +4     
============================================
  Files           843      843              
  Lines         26141    26141              
  Branches       5100     5100              
============================================
+ Hits          21495    21502       +7     
+ Misses         3854     3847       -7     
  Partials        792      792              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jkhaleed Jkhaleed left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test correctly checks the expected surface area for a valid square pyramid. Could we also add a test using a negative side length to verify the input validation handles all non-positive values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants