AD new-forest: validate NetBIOS + reject member server before DSRM prompt (v1.121.7)#75
Merged
Merged
Conversation
…RM prompt (v1.121.7) A deep audit confirmed the AD module's security-critical parts (DSRM SecureString hygiene, credential handling, promotion parameters, irreversible-op warnings) are already correct. Two new-forest input-validation gaps remained, both fixed in Install-NewForest so they fail fast BEFORE the DSRM password is collected: - Validate the derived NetBIOS name length (<= 15) — a first label > 15 chars otherwise fails minutes into Install-ADDSForest, after the DSRM password. - Reject a domain-joined member server (DomainRole 1/3) with guidance to use "Add Domain Controller" — scoped locally to Install-NewForest, NOT the shared Test-ADDSPrerequisites (which Add-DC / RODC reuse, where a member is valid). - Tests: new Run-Tests Section 194 (incl. a regression guard that the shared prereq still uses -ge 4). Version bump to 1.121.7.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deep AD audit confirmed the security-critical parts (DSRM SecureString hygiene, credentials, promotion params) are correct. Two new-forest input-validation fixes so they fail fast before the DSRM password: NetBIOS length <= 15, and reject a domain-joined member server (scoped to Install-NewForest, not the shared prereq). Suite 5284/5284, PSSA 0.