Failover Clustering safety: quorum guards + CSV data-loss guard + witness validation (v1.121.6)#74
Merged
Merged
Conversation
…oss guard, witness validation (v1.121.6) Deep audit of the clustering module found call sites that failed to reuse the module's own correct safety patterns. - Dashboard node-drain now checks for another Up node + quorum before Suspend-ClusterNode -Drain (mirrors Suspend-ClusterNodeForMaintenance), instead of a bare confirm that could take the cluster offline (51-ClusterDashboard). - Node-eviction undo uses size-aware post-eviction quorum math instead of a hardcoded '-le 2' that let 4+ node clusters lose quorum (27-FailoverClustering). - CSV removal aborts when the mount point can't be resolved, instead of running a VM-dependency scan that matches nothing and falsely reports 'no VMs' — which could destroy live-VM storage. - Disk witness must be Online; file-share witness gets a Test-Path reachability pre-flight + a cluster-name-object ACL reminder. - Show-CSVHealth uses Get-ClusterSharedVolumeState.FileSystemRedirectedIOReason instead of the always-true SharedVolumeInfo.FaultState comparison (no more false 'redirected I/O' warnings on healthy CSVs). - Cluster validation report is saved to a known path and its location printed. - Tests: new Run-Tests Section 193. Version bump to 1.121.6.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deep audit of the clustering module found 7 real bugs (3 high). Dashboard drain + node eviction now preserve quorum (size-aware); CSV removal aborts when it can't verify VM dependencies (data-loss guard); disk/file-share witness validated; false redirected-I/O warning fixed; validation report location shown. Every fix mirrors a correct pattern already in the module. Suite 5279/5279, PSSA 0.