Repository navigation
chore: declare licence, publish symbols, and clear redundant code - #37
Merged
Merged
Conversation
Packaging - Declared PackageLicenseExpression MIT on all three packages. The repo has an MIT LICENSE file but none of the packages ever said so, and every push logged "License missing". - Added IncludeSymbols/IncludeSource/SourceLink settings. Console was one of the few shipping repos with no symbol support at all, so consumers could never step into the source. - SymbolPackageFormat is snupkg, not the legacy .symbols.nupkg. That name still ends in .nupkg, so the release push loop would upload it as a regular package and nuget.org would reject it as a duplicate - which is how symbols failed silently everywhere else in the toolkit. CI - A failed nuget push now fails the release. The loop ended in `|| true`, so no push could ever fail the job. --skip-duplicate already makes re-pushing an existing version a success, so anything that still fails is real. Also lists ./artifacts first, so the log shows the .snupkg next to its .nupkg. Code - Removed 20 overrides whose bodies only forwarded to base, and the usings they were the last consumers of. The empty overrides are left alone: those deliberately suppress base behaviour and are not redundant. - Removed a redundant empty constructor and an unused System.Text.Json reference in the sample, which was raising NU1510. .editorconfig - Test classes are named as sentences on purpose (With_command_line, When_writing_a_line) because the class name is the "given" half of the test description and reads directly in runner output. ReSharper's default rules wanted PascalCase types and _camelCase fields, which would destroy that, so InconsistentNaming is off under **/*.Tests/**. - Also records the PascalCase convention for static readonly fields. ReSharper warnings 130 -> 89. 44 tests pass.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General cleanup of the Console repo.
Packaging
License missing.IncludeSymbolsat all, so consumers could never step into the source. Usessnupkg, not the legacy.symbols.nupkg— that name still ends in.nupkg, so the push loop would upload it as a regular package and nuget.org would reject it as a duplicate, which is how symbols failed silently across the rest of the toolkit.System.Text.Jsonreference in the sample (NU1510).CI
|| true, so nothing a push did could fail the job.--skip-duplicatealready makes re-pushing an existing version a success, so anything that still fails is real.Code
.editorconfig
Test classes are named as sentences on purpose (
With_command_line,When_writing_a_line) because the class name is the "given" half of the test description and reads directly in runner output. ReSharper's defaults wanted PascalCase types and_camelCasefields, which would destroy that, soInconsistentNamingis off under**/*.Tests/**.ReSharper warnings 130 → 89. 44 tests pass, 2 skipped.