Repository navigation
Package icon, docs site, and integrated docs CI - #35
Merged
Merged
Conversation
- Bump <PackageIconUrl> in all three csproj files to https://thargelion.net/assets/component-console.png - Add DocFX site under docs/ (console.tharga.net), modeled on Tharga.Test: index + 4 articles (getting-started, commands, consoles, dependency-injection), custom thg template for navbar logo sizing, generated _site/ + api/ + obj/ gitignored - Fold docs build + Pages deploy into build.yml as docs / docs-deploy jobs gated on `needs: release`, per the integrated-pattern guidance used in Tharga.Runtime and Tharga.Test - README links to console.tharga.net
DocFX 2.78.5's modern _master.tmpl prepends _rel (the relative-depth prefix, e.g. "../") to _appFaviconPath and _appLogoPath without checking whether the configured value is already an absolute URL. On sub-pages that turned src="https://thargelion.net/assets/component-console.png" into src="../https://thargelion.net/assets/component-console.png" which 404'd, surfacing the broken-image alt text in the navbar so the brand name appeared twice (alt-text + the {{_appName}} label). Overlay a templates/thg/layout/_master.tmpl that moves _rel into the fallback path only — absolute URLs render as-is, the local logo.svg/favicon.ico fallbacks still resolve from the site root.
|
Released as v4.1.2 — https://github.com/Tharga/Console/releases/tag/4.1.2 |
5 of 11 tasks
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles the two
2026-06-01Internal requests for this repo, modeled on Tharga.Test commitd6b9efb:Tharga.Console,Tharga.Console.Standard,Tharga.Console.Speech) updated from the oldhttp://thargelion.se/wp-content/uploads/...WordPress URL tohttps://thargelion.net/assets/component-console.png.docs/tree, CNAME →console.tharga.net, 4 articles (getting-started, commands, consoles, dependency-injection) + API reference across all three csprojs. Customtemplates/thgfor navbar logo sizing.docs+docs-deployjobs added to.github/workflows/build.yml, gated onneeds: releaseso they only run when a published version succeeds.pages: write+id-token: writepermissions added at the workflow root.**Docs:**link near the top, matching the sibling pattern (Test, Communication).Pre-reqs verified
https://thargelion.net/assets/component-console.pngreturns200 OK(Cloudflare HIT).console.tharga.netresolves via DNS.Test plan
dotnet build -c Releaseclean (0 warnings, 0 errors across net8/net9/net10 + netstandard2.0).dotnet test -c Release— 44 pass / 0 fail / 2 pre-existing skips.docfx docs/docfx.json) — 0 errors, 1 benign warning about project-reference load order.4.1.xpatch, thendocs+docs-deployjobs run andconsole.tharga.netserves the new site.console.tharga.net(same step Tharga.Test mentioned in its status entry).