Repository navigation
chore(deps)!: consume Tharga.Mcp 2.0.0 and Runtime 1.0.2 - ships as 1.1.0 - #20
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Released as v1.1.0 — https://github.com/Tharga/Communication/releases/tag/1.1.0 |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tier 1 of the cascade sweep, consuming the tier 0 releases. Ships as 1.1.0, not a patch — see below.
Internal
Tharga.Runtime1.0.1 → 1.0.2Tharga.Mcp1.1.0 → 2.0.0 (inTharga.Communication.Mcp) — a majorTharga.Test.Toolkit1.14.13 → 1.14.15 (test project)All verified by an actual
dotnet restore.Why this is 1.1.0
MAJOR_MINORgoes1.0→ 1.1.Tharga.Mcp2.0.0 reducesIMcpContexttoScopeand removesUserId,TeamIdandIsDeveloper. That type is not an internal detail here — it appears in the public signatures ofCommunicationResourceProvider:So anyone consuming
Tharga.Communication.Mcpand reading identity off that context is broken by this upgrade, transitively. A patch number would hand them that on a routinedotnet outdated -u— exactly the complaint that madeTharga.Mcpitself ship as a minor rather than 1.0.2.This repo's own code needed no change — it passes the context through and never read the removed members. Build is clean and all 120 tests pass, which is what confirms the break is transitive only.
Verification
dotnet build -c Release --no-incremental— 0 warnings, 0 errors.dotnet test -c Release— 120/120 passing.Workflow re-validated with the duplicate-key-rejecting YAML loader after the
MAJOR_MINORedit.Also in this release
The
.claude/mission.mdcleanup merged before this branch was cut —$DOC_ROOTfor the requests path, and the consumer-project reference removed.xunit remains at 3.x here by decision; the 3 → 4 migration is deferred (see the parked PRs on Fortnox and Runtime).