fix(homebridge): remove unearned verified badge, test Node 22/24, correct energy-streaming README text - #123
Merged
Merged
Conversation
… text, test Node 22/24 The verified-by-homebridge badge claimed a status the plugin doesn't have on the official verified-plugins list. The README also still described energy sites as periodically polled when live_status has been SSE-streamed for a while; only site_info is polled. CI now runs the full suite across a Node 22/24 matrix instead of Node 24 only.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9718798a2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
Author
|
Fixed in bbdc19c — backup reserve is read from the polled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
homebridge-teslemetryis not present in the officialverified-plugins.jsonas of today.config.schema.jsonsettings GUI, and catches/logs its stream and command errors. The one gap worth checking before applying is whether theengines.noderange (>=18.0.0) should be tightened to reflect the versions actually tested in CI (see below).>=18enginesrange inpackage.jsonwas never actually verified.node-version: ["22", "24"]matrix toreusable-ci.yml(the repo's one shared CI workflow) so every PR runs lint/build/typecheck/test on both.homebridge-teslemetry's build and full test suite (156/156) pass on both Node 22.18.0 and Node 24.18.0 before opening this PR.live_status(power flow, backup reserve, etc.) has been SSE-streamed for a while — onlysite_infois still polled. Corrected the text.Full narrative / original brief
Resolve verification/discovery truth, validate Node 22/24, and correct the README's energy-streaming text for the Homebridge plugin. Verified each claim against current code and the live verified-plugins list before acting, since the source audit predated three merged PRs (#116, #118, #121).