test: confirm and fixture steering-wheel-heat command tags 70/71 - #31
Merged
Conversation
…70/71) Confirms VehicleAction.autoStwHeatAction=70 (AutoStwHeatAction.on bool) and VehicleAction.stwHeatLevelAction=71 (StwHeatLevelAction.stw_heat_level enum, Unknown=0/Off=1/Low=2/High=3) against the declared proto, and locks the exact wire bytes with a shared JSON fixture consumed by both generated packages' test suites (node:test, unittest), wired into CI. Confirmation-only: no schema changes, no changeset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
proto/command/car_server.proto:VehicleAction.autoStwHeatAction=70(AutoStwHeatAction.on, bool) andVehicleAction.stwHeatLevelAction=71(StwHeatLevelAction.stw_heat_level, enumUnknown=0/Off=1/Low=2/High=3).python-tesla-fleet-apitest suite (tests/test_ble_climate_commands.py), which documents both commands as live-attempted against a real test vehicle: the vehicle's ACK decodes correctly and returns the feature-specific rejectioncabin comfort remote settings not enabled, rather than a parse failure - confirming the vehicle recognizes these exact field/tag/payload combinations. That repo's independentStwHeatLevelsmapping (1/2/3 ->Off/Low/High) matches this repo's declaration.fixtures/golden/steering_wheel_heat.json) covering tag-70 off/on and all four tag-71 enum values, with the outerAction.vehicleAction=2wrapper tag identified alongside each case.packages/typescript/test/,node --test;packages/python/tests/,unittest) load the same fixture and assert both encoders produce byte-identical output and both decoders round-trip it back to the same values. Wired intoci.ymlafter each package's build step.unittestcoverage existed); documented inAGENTS.md.Lowenum value;Unknown/Off/Highshare the same confirmed field/tag mapping and are exercised by the fixture's local encode/decode round-trip but weren't individually sent to the test vehicle.