feat(session): support unfocused agent windows - #54
Open
alectimison-maker wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bsk session start --no-focusso Agent Windows can open without stealing focusfocusedvalue through the CLI, daemon, protocol, and extensionCloses #26.
Why
bsk session startcurrently hardcodesfocused: trueat the Chrome window boundary. That interrupts users who want an agent session to start while they continue working in another window.The new flag is opt-in. Existing callers omit
focused, and the extension continues to default it totrue.Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo test --workspace --lockedcorepack pnpm lintcorepack pnpm --filter @browser-skill/extension compilecorepack pnpm --filter @browser-skill/extension test(44 files, 497 tests)corepack pnpm --filter @browser-skill/extension buildnode --test scripts/*.test.mjsCompatibility
The protocol field is optional and omitted by default. Older clients therefore keep the current focused behavior, while
--no-focusexplicitly sendsfocused: false.