Fix #26: Modal focus trap for Settings / Add role / JD triage - #39
Open
partbomb wants to merge 1 commit into
Open
Fix #26: Modal focus trap for Settings / Add role / JD triage#39partbomb wants to merge 1 commit into
partbomb wants to merge 1 commit into
Conversation
Contributor
|
Thank you for picking up #26 — the Tab / Shift+Tab cycle while a A couple of pieces from the issue still missing before we can merge as “fixes #26”:
Happy to merge once those land. Appreciate you taking the a11y work. |
telivity-otaip
requested changes
Aug 31, 2026
telivity-otaip
left a comment
Contributor
There was a problem hiding this comment.
Thank you for picking up #26 — the Tab / Shift+Tab cycle while a .modal is open is exactly the right shape, and CI looks good.
A couple of pieces from the issue still missing before we can merge as “fixes #26”:
- Initial focus on Settings — Add role / JD triage already focus a field; Settings open still leaves focus behind the dialog. Please move focus into
#settingswhen it opens (first input or close control is fine). - Restore focus to the opener on close — when Settings / Add role / JD triage close, return focus to the button that opened them.
- Accessible name — give each of those modals
aria-labelledby(pointing at the existing heading) oraria-label, matching the drawer’s dialog pattern.
Happy to merge once those land. Appreciate you taking the a11y work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a keyboard focus trap for modals (Settings, Add role, JD triage) when using the Tab key, improving accessibility. Fixes #26.