Land the two changes that merged into a branch instead of master - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#56 and #58 never reached master. My fault: I opened both against
unicode-classesrather thanmaster, so when they were merged they went into that branch, which is where they still are. GitHub reports them as merged, and they are — just not here.This replays the two commits onto current master, without disturbing what has landed since. It carries no
grammars.dat: master's was regenerated after #55 and #57, and the bot will regenerate it again for this, becausegenerate.jsis in the workflow's path filter.generate.jsfrom Escape characters a pattern cannot carry as bytes #58 —escapeNonAsciiinsanitize, andwriteStringencoding UTF-8 rather than one byte per code unit. Cherry-picked onto master's copy, so Give an alias the language title when it has none of its own #57's alias-title fallback is untouched..github/workflows/check-grammars.ymlandtools/from Check every pattern against both regex engines on a pull request #56 — the escape allowlist, both engines compiling every pattern, and the diff of what each one matches.Merging
unicode-classesdirectly would not have worked: it predates #57 and carries an oldergrammars.dat, so it would have reverted both.Once this is in, the
.datthe bot produces should drop the last 33 patterns holding a truncated byte, and the check this adds will be running on every pull request that touches a grammar.Please delete
unicode-classes,check-grammarsandwrite-stringafterwards, so the merged-but-stranded commits cannot be mistaken for live branches.🤖 Generated with Claude Code