fix(keycloak): carry emailSentMessage into techgarden theme (WS-05) - #277
Merged
Conversation
The forgot-password success alert was still stock Keycloak. Found by the orchestrator during stage-3 live validation, not reachable locally: info.ftl never renders in that flow — Keycloak returns the same response whether or not the account exists, as an alert back on the sign-in page. login/messages/messages_en.properties copied verbatim from the app repo at 24af3ca8 (blob d7fc75a). One key added, emailSentMessage, plus its comment; the wording still does not confirm the account exists, so the anti-enumeration property is preserved. Diffed the whole tree: the other 17 files are byte-identical, so nothing else moved. Bumps techgarden.gg/theme-revision 1 -> 2. The theme ConfigMaps have stable names and Keycloak caches themes for 30 days in production mode, so without this the ConfigMap would update and the old bytes would keep being served. Refs: WS-05, TechGardenCode/techgarden#181, #275 Claude-Session: https://claude.ai/code/session_01S5ph2xAnD7oCR8YmFmobDn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage-3 finding from the WS-05 orchestrator. Follow-up to #275.
What
The forgot-password success alert was still stock Keycloak ("You should receive an email shortly with further instructions."). Not reachable locally —
info.ftlnever renders in that flow, because Keycloak returns the same response whether or not the account exists and surfaces it as an alert back on the sign-in page.login/messages/messages_en.propertiescopied verbatim from the app repo at24af3ca8:One key added —
emailSentMessage— plus its comment. The wording still does not confirm the account exists, so the anti-enumeration property is preserved.I''vecarries the doubled apostrophe MessageFormat needs.I diffed the whole tree against app-repo
main, not just the named file: the other 17 files are byte-identical. Nothing else moved, and nothing was re-authored here.Pod roll
Bumps
techgarden.gg/theme-revision1 → 2. This is exactly the case that annotation exists for: the theme ConfigMaps have stable names and Keycloak caches themes 30 days in production mode, so without the bump the ConfigMap would update and the pod would keep serving the old bytes.Validation
kustomize build kubernetes/clusters/1276-dev/keycloak/keycloak— passemailSentMessagepresent in the rendered bundletechgarden.gg/theme-revision: "2"🤖 Generated with Claude Code
https://claude.ai/code/session_01S5ph2xAnD7oCR8YmFmobDn