[improve/#433] OAuth state 쿠키 보안 속성 정리#443
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
OAuth2/OIDC authorization request(state) cookie의 보안 속성을 명시했습니다.
oauth2_auth_request저장 cookie에HttpOnly,Secure,SameSite=None,Path=/,Max-Age=180적용HttpOnly,Secure,SameSite=None,Path=/속성과Max-Age=0으로 생성Domain은 설정하지 않아 기존처럼 host-only cookie로 유지Cookie가 표현하지 못하는SameSite검증을 위해ResponseCookie+Set-Cookieheader 방식으로 변경errorCode=oauth_failed로 정리된 상태라, 이번 PR에서는 추가 변경하지 않았습니다.Swagger 테스트 성공 결과 스크린샷 첨부
연결된 issue
close #433
🩷 Approve 하기 전 확인해주세요!
oauth2_auth_requestcookie는SameSite=None; Secure고정 정책입니다. local HTTP OAuth 브라우저 플로우는 보장하지 않고, local 검증은 HTTPS/local-tunnel 기준입니다.auth/security내부 store/cache/cookie 책임 명명 정리는 #442에서 별도로 처리합니다.✅ 체크리스트
🧪 테스트 결과
🔎 리뷰 결과