[refactor/#431] OAuth/OIDC 보안 인프라 책임 분리#441
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
OAuth/OIDC 로그인 보안 인프라의 책임 경계를 분리했습니다.
HttpCookieOAuth2AuthorizationRequestRepositoryTest로 authorization request cookie 저장/조회/삭제 동작을 보강OAuth2LoginRedirectUrlFactory로 분리errorCode=oauth_failed만 노출하도록 변경OAuth2LoginTokenIssuer로 분리OAuth2LoginRefreshTokenWriter로 분리OidcSocialIdentityExtractor로 분리해CustomOidcUserService는 오케스트레이션만 담당하도록 정리CustomOidcUserServiceTest를 흐름이 보이도록 helper method 기반으로 정리handler.login패키지 내부 helper/factory/value 타입은 package-private으로 닫아 handler 내부 협력 객체임을 명시Swagger 테스트 성공 결과 스크린샷 첨부
연결된 issue
close #431
🩷 Approve 하기 전 확인해주세요!
handler.login의OAuth2LoginRedirectUrlFactory,OAuth2LoginTokenIssuer,OAuth2LoginRefreshTokenWriter,OAuth2LoginTokens는 의도적으로 package-private입니다. 외부 패키지 재사용 대상이 아니라 login handler 내부 협력 객체입니다.✅ 체크리스트
🧪 테스트 결과
참고 검증:
🔎 리뷰 결과