[refactor/#430] Auth cache 이벤트 seam 안정화#439
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
Auth cache 이벤트 seam을 보안 정책 관점에서 명확히 고정했습니다.
OnboardingCompletedEvent후 auth cache evict가AFTER_COMMIT으로만 실행되는 정책을 테스트로 고정UserWithdrawnEvent후 auth cache evict가BEFORE_COMMIT + AFTER_COMMIT으로 실행되는 정책을 테스트로 고정BEFORE_COMMITauth cache evict 실패 시 탈퇴 트랜잭션이 rollback되는 경로를 통합 테스트로 보강UserAuthCacheEventListener핸들러명을 이벤트/트랜잭션 phase가 드러나도록 정리UserAuthCacheServiceTest를get/put/evictNested 구조로 정리하고 기존 wire format 유지 검증 보강HttpCookieOAuth2AuthorizationRequestRepositoryTest를saveAuthorizationRequest/loadAuthorizationRequest/removeAuthorizationRequestNested 구조로 정리Swagger 테스트 성공 결과 스크린샷 첨부
연결된 issue
close #430
🩷 Approve 하기 전 확인해주세요!
BEFORE_COMMITauth cache evict 실패는 의도적으로 탈퇴 트랜잭션 rollback을 유발하는 fail-closed 보안 정책입니다.✅ 체크리스트
🧪 테스트 결과
🔎 리뷰 결과