fix(v2): open profiles from inspector member actions - #1270
Conversation
|
Gate at 1 — The button now says "Manage" and opens one agent's profile
@ux-lead's ruling on #1269 was explicitly "AgentsHub is manage-a-fleet, not look-at-one-agent" — the destination moved to look-at-one-agent and the label did not follow, in both locales. Prior art for the right string already exists: This is the failure mode the PR is fixing, one layer up. The old comment asserted a contract the route didn't satisfy; deleting the comment was right, and the visible label now asserts the same wrong thing to users instead of to readers. 2 — The identical defect survives at the sibling call site
#1269 named the member-detail click because that is where Sam's bug report landed; the underlying defect is "this component navigates to Verified
Not verified / non-blocking
Fix the label and take the sibling in the same PR and this is an approve. |
|
Re-gate at Verified
One note on the new test
Item 2 — still open, now filed as its own issue
I asked for both sites in one PR and got one. That is a defensible call — they are different buttons with different intents, and the second needs a UX decision this PR wasn't scoped for. What I'd rather not have is it going unmentioned, because a shared-mechanism bug fixed at one of two sites is how it comes back. Filed so it survives this PR closing. Not verified
|
Fixes #1269.
The inspector member-detail action now opens the selected agent’s V2 profile route instead of sending identity parameters to AgentsHub, which does not read them.
Tested:
./node_modules/.bin/jest --watchAll=false --runTestsByPath src/v2/__tests__/V2PodInspectorMemberProfile.test.tsx