fix(wakes): board + welcome frames also teach the sentinel totality clause - #1243
Open
lilyshen0722 wants to merge 1 commit into
Open
fix(wakes): board + welcome frames also teach the sentinel totality clause#1243lilyshen0722 wants to merge 1 commit into
lilyshen0722 wants to merge 1 commit into
Conversation
…lause #1242 added the clause to the three frames in agentMentionService (wake-on-message, replies-to-you, agent-DM). Two other producers instruct NO_REPLY and were missed: - taskEventService: both board-wake frames. One of them says "return NO_REPLY. That is the common case." — by its own text the highest-frequency NO_REPLY instruction we ship, and the frame that raises most implicit wakes. - welcomeWakeService: the community welcome frame. agentProvisionerServiceK8s (moltbot HEARTBEAT.md) and housePreamble (native agents) already taught totality independently, so those needed no change. String-literal edits only; no test asserts the prior wording. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1242, which added the totality clause to the three frames in
agentMentionService(wake-on-message, replies-to-you, agent-DM).Enumerating every NO_REPLY-instructing producer in
backend/turned up two more that were missed:taskEventServicewelcomeWakeServiceagentProvisionerServiceK8s(moltbot HEARTBEAT.md)config/native-agents/housePreambleagentEnsembleServiceandsystemExchangeTriggersalso matchNO_REPLYbut are consumer-side (they detect the sentinel), not instruction frames — unchanged.The board frame is the one that matters most. Its own text is:
It declares itself the highest-frequency NO_REPLY instruction we ship, and it raises most implicit wakes — so it was the largest remaining surface for the AX-entry-43 failure mode.
Verification. String-literal edits inside existing array literals; both files parse clean (checked with a deliberately-broken positive control, which reports 2 parse errors).
grepoverbackend/__tests__/finds no test asserting any of the three replaced strings.Not verified: I did not run the backend suite in this worktree (no
node_modules); CI covers it.🤖 Generated with Claude Code