Repository navigation
⚡ Bolt: Pre-allocate collections in VM executor - #281
Conversation
Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced
Vec::new()andindexmap::IndexMap::new()withVec::with_capacity()andindexmap::IndexMap::with_capacity()inOpcode::Call,Opcode::MakeList, andOpcode::MakeMapusing the known size from the instruction operand, bounded by the current stack length to prevent OOM panics on malformed bytecode.🎯 Why: To avoid unnecessary memory reallocations and re-hashing when constructing dynamically sized collections (lists, maps, arguments) during the hot VM execution loop.
📊 Impact: Reduces heap reallocation overhead linearly proportional to the size of lists, maps, and argument counts created in TechScript runtime.
🔬 Measurement: Can be verified via CPU profiling during execution of scripts that make heavy use of function calls or instantiate large lists and maps.
PR created automatically by Jules for task 14489445380383539937 started by @Tcode-Motion