Feature task 3949 review editor selection

[shweta2101]

DevBoard Task

https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3949/

Changes implemented

• Added an editor dropdown beside Edit Here in the Review view.
• Dropdown options:
  • Rapid 2 (default)
  • Rapid 3 (beta)
• The selected editor is included in the URL:
  • Rapid 2 -> editor=rapid
  • Rapid 3 -> editor=rapid3
• The current map location is preserved when opening either editor.
• The button label remains Edit Here.

Areas impacted for testing

• Review page Edit Here dropdown visibility.
• Rapid 2 navigation and editor=rapid URL.
• Rapid 3 navigation and editor=rapid3 URL.
• Map coordinates remain in the URL after navigation.
• Editor switching by changing editor=rapid to editor=rapid3, or vice versa, and reloading.
• Non-OSW workspaces retain the existing single Edit Here button.
• Existing Review toolbar actions still work.

Screenshots

Summary

• Added a Rapid editor dropdown beside Edit Here for OSW workspaces when Rapid 3 is available. The menu offers Rapid 2 and Rapid 3.
• Passed the selected editor through the review overlay and toolbar to editor navigation. OSW navigation includes the selected editor query parameter. Other workspace types retain the existing edit button and navigation behavior.
• Updated E2E expectations and a snapshot. Added toolbar unit tests for editor choices and emitted events.

Tests

The changes add E2E and unit test coverage. Test execution results were not provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 88dca1d8-65c0-40b4-8283-1c98f67314ae

---

📥 Commits

Reviewing files that changed from the base of the PR and between 2d6dca2 and 572afa3.

---

📒 Files selected for processing (6)

• components/review/Overlay.vue
• components/review/Toolbar.vue
• pages/workspace/[id]/review.vue
• test/e2e/review.spec.ts
• test/e2e/review.spec.ts-snapshots/workspace-review-clicking-an-item-shows-its-details-and-an-attribute-diff-panel-1.aria.yml
• test/unit/components/ReviewToolbar.test.ts

---

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

---

📝 Walkthrough

Walkthrough

The review toolbar now offers Rapid editor selection in eligible OSW workspaces. The selected editor is passed to review navigation, where OSW routes include the editor query parameter. Tests cover Rapid and Rapid 3 selection and navigation.

Changes

Review editor selection

Layer / File(s)	Summary
Toolbar editor choices and event contract components/review/Toolbar.vue, components/review/Overlay.vue, test/unit/components/ReviewToolbar.test.ts, test/e2e/review.spec.ts-snapshots/*	The toolbar offers Rapid 2 and Rapid 3 options for OSW workspaces when Rapid 3 is available. It emits the selected editor, which the overlay passes to its edit callback. Unit tests and the accessibility snapshot cover the toolbar controls.
Editor-aware navigation pages/workspace/[id]/review.vue, test/e2e/review.spec.ts	The review page adds the selected editor to the navigation query for OSW workspaces. End-to-end tests check Rapid and Rapid 3 navigation and map location.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant ReviewToolbar
  participant Overlay
  participant ReviewPage
  participant Router
  ReviewToolbar->>Overlay: emit edit with selected editor
  Overlay->>ReviewPage: call onEdit with selected editor
  ReviewPage->>Router: navigate with editor query for OSW

Loading

Suggested reviewers: jeffmaki

---

Merge Risk: ⚪ Minimal · up to 572af

The reported test failure does not occur for the stated reason, and no remaining issue is established that would prevent merging after normal checks.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the main change: adding review editor selection for task 3949. It is concise and directly related to the pull request changes.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/review/Overlay.vue

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

---

components/review/Toolbar.vue

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

---

pages/workspace/[id]/review.vue

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

---

• 2 others

---

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{A rabbit taps Rapid two,
Then picks Rapid three from the menu.
The review sends the choice along,
To the route where maps belong.
Hop, the feedback comes into view!}

_{Comment @coderabbitai help to get the list of available commands.}