Skip to content

[DO NOT MERGE] - Testing #474 and #475 (GSM Secrets) on oasis staging - #482

Closed
yuechao-qin wants to merge 1 commit into
ycq/staging-integration-expires-atfrom
ycq/staging-integration-gsm
Closed

yuechao-qin wants to merge 1 commit into
ycq/staging-integration-expires-atfrom
ycq/staging-integration-gsm

Conversation

@yuechao-qin

Copy link
Copy Markdown
Collaborator

Do not merge. A test branch for oasis staging: it adds #474 and #475 (the optional secret store) to the commit oasis staging already pins, so staging can run them before they merge.

What is in it

5c27ace — the commit oasis staging pins today, the head of #478 — plus one commit with the own changes of #474 and #475 (0ab5fc8..50be2e0). They are applied rather than merged, so the 14 master commits staging does not run yet stay out.

Base

The base is ycq/staging-integration-expires-at, #478's branch, at 5c27ace. The diff is therefore only #474 and #475: 5 files, +541 / −5.

Checks

Check Result
apply clean; every changed line is identical to #474 and #475's own
pytest 644 passed (623 on 5c27ace, plus 21 new); the 22 tests/instrumentation/test_execution_tracing.py failures also fail on 5c27ace
black --check ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant