Skip to content

Add BYOK component search settings hook#2316

Merged
Mbeaulne merged 2 commits into
masterfrom
05-27-agent-settings-ai-rerank-service
Jun 5, 2026
Merged

Add BYOK component search settings hook#2316
Mbeaulne merged 2 commits into
masterfrom
05-27-agent-settings-ai-rerank-service

Conversation

@Mbeaulne

@Mbeaulne Mbeaulne commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Tophatting

No manual tophatting required. This PR only adds the settings storage hook and unit tests.

What changed

Adds a small settings hook for Components V2 AI search configuration.

The hook stores these values in browser localStorage:

  • API base URL
  • API key
  • model id

It also handles old saved config that used thinkingModel.

Why

AI search uses a bring-your-own-key setup. This PR only adds the storage layer; it does not add UI or call an AI provider yet.

Test plan

  • Run pnpm exec vitest run src/hooks/useComponentSearchSettings.test.ts
  • Run pnpm run typecheck --pretty false
  • Confirm empty settings report as not configured
  • Confirm saved settings load back from localStorage

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 05-27-agent-settings-ai-rerank-service/1fb6bb7

@Mbeaulne Mbeaulne force-pushed the 05-27-agent-settings-ai-rerank-service branch from 988d36e to aa37795 Compare May 27, 2026 20:07
@Mbeaulne Mbeaulne force-pushed the 05-27-component-search-index-service branch from 3028b43 to bfc7f76 Compare May 27, 2026 20:07
@Mbeaulne Mbeaulne force-pushed the 05-27-agent-settings-ai-rerank-service branch 2 times, most recently from 6d8a2b9 to 8d45929 Compare May 27, 2026 20:27
@Mbeaulne Mbeaulne changed the title Add agent settings and AI rerank service Add BYOK component search settings hook May 27, 2026
@Mbeaulne Mbeaulne force-pushed the 05-27-agent-settings-ai-rerank-service branch from 8d45929 to 38e0b45 Compare May 27, 2026 20:29
@Mbeaulne Mbeaulne force-pushed the 05-27-component-search-index-service branch from 1a766b2 to d2b079d Compare May 27, 2026 23:18
@Mbeaulne Mbeaulne force-pushed the 05-27-agent-settings-ai-rerank-service branch from 38e0b45 to 3125081 Compare May 27, 2026 23:18
@Mbeaulne Mbeaulne force-pushed the 05-27-component-search-index-service branch from d2b079d to 40d2a10 Compare May 28, 2026 17:25
@Mbeaulne Mbeaulne force-pushed the 05-27-agent-settings-ai-rerank-service branch from 3125081 to 3cbeeb6 Compare May 28, 2026 17:25
@Mbeaulne Mbeaulne force-pushed the 05-27-component-search-index-service branch from 40d2a10 to 2c76487 Compare May 28, 2026 18:37
@Mbeaulne Mbeaulne force-pushed the 05-27-agent-settings-ai-rerank-service branch 3 times, most recently from 0f078bc to c4dd973 Compare June 3, 2026 13:42
@Mbeaulne Mbeaulne mentioned this pull request Jun 3, 2026
8 tasks
@Mbeaulne Mbeaulne force-pushed the 05-27-agent-settings-ai-rerank-service branch from c4dd973 to fff5c0d Compare June 3, 2026 15:13
@Mbeaulne Mbeaulne force-pushed the 05-27-component-search-index-service branch from 5059b41 to 77f15d0 Compare June 3, 2026 15:13
@Mbeaulne Mbeaulne mentioned this pull request Jun 3, 2026
8 tasks
@Mbeaulne Mbeaulne marked this pull request as ready for review June 3, 2026 15:28

@morgan-wowk morgan-wowk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI-assisted review — one finding on the settings update() write path.

Comment thread src/hooks/useComponentSearchSettings.ts Outdated

@morgan-wowk morgan-wowk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments

Comment thread src/hooks/useComponentSearchSettings.ts Outdated
Comment thread src/hooks/useComponentSearchSettings.ts
Comment thread src/hooks/useComponentSearchSettings.ts Outdated
Comment thread src/hooks/useComponentSearchSettings.ts Outdated
@Mbeaulne Mbeaulne force-pushed the 05-27-agent-settings-ai-rerank-service branch from fff5c0d to 39aee24 Compare June 4, 2026 20:43
@Mbeaulne Mbeaulne force-pushed the 05-27-component-search-index-service branch from d1f0f80 to 1b2dc48 Compare June 4, 2026 20:52
@Mbeaulne Mbeaulne force-pushed the 05-27-agent-settings-ai-rerank-service branch 2 times, most recently from 18bcfe1 to 6a60fc3 Compare June 4, 2026 21:03
@Mbeaulne Mbeaulne force-pushed the 05-27-component-search-index-service branch from 1b2dc48 to 21b5ff8 Compare June 4, 2026 21:03

Mbeaulne commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Jun 5, 2:37 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 5, 2:43 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 5, 2:46 PM UTC: @Mbeaulne merged this pull request with Graphite.

@Mbeaulne Mbeaulne changed the base branch from 05-27-component-search-index-service to graphite-base/2316 June 5, 2026 14:37
@Mbeaulne Mbeaulne changed the base branch from graphite-base/2316 to master June 5, 2026 14:41
Mbeaulne and others added 2 commits June 5, 2026 14:42
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@Mbeaulne Mbeaulne force-pushed the 05-27-agent-settings-ai-rerank-service branch from bf52e92 to 1fb6bb7 Compare June 5, 2026 14:42
@Mbeaulne Mbeaulne merged commit ddbcb74 into master Jun 5, 2026
17 checks passed
@Mbeaulne Mbeaulne deleted the 05-27-agent-settings-ai-rerank-service branch June 5, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants