Repository navigation
Key a child's compile on its own task_annotations (v0.1.37) - #86
Merged
Merged
Conversation
A child's compile key folded in the call-site defaults pushed into it, but not its own `@pipeline(task_annotations=...)`. Two wrappers over one function with the same name and config but different own defaults, used side by side, shared one sidecar, and the second silently got the first's annotations. The child's own defaults, resolved as its trace applies them (a mapping, or a function of the child's cfg), are now part of its compile key. Without own defaults, keys are unchanged.
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A child's compile key already folds in the call-site defaults pushed into it (
subpipeline(child).with_task_annotations(...), #85), but not the child's own@pipeline(task_annotations=...). TwoPipelineFnwrappers over one function body, with the same name and config but different owntask_annotations, used side by side, therefore shared one compiled child (one sidecar), and the second silently got the first's annotations.The child's own defaults, resolved as its trace applies them (a mapping, or a function of the child's resolved cfg: its config plus effective overrides), are now part of its compile key, in their own
"\x00own_task_annotations"envelope slot. That slot is kept separate from the call-site"\x00task_annotations"slot because the two flow differently: own defaults apply only to the child's body, while call-site defaults also flow on to its descendants. Without own defaults, keys are unchanged.Tests: wrappers differing only in their own defaults (mapping and function) compile to separate sidecars, each carrying its own annotations. Equal own defaults still share one sidecar, including two distinct functions that resolve to the same mapping.
Bumps the version to 0.1.37.
Raised in review of the shop/world vendoring of tangle-cli @ 078744a: https://delta.shopify.io/shop/world/pull/2480347#discussion_r2600832335882