Repository navigation
fix: retain human name in messages to agents - #198
Open
maxy-shpfy wants to merge 1 commit into
Open
maxy-shpfy wants to merge 1 commit into
maxy-shpfy wants to merge 1 commit into
Conversation
maxy-shpfy
marked this pull request as ready for review
November 19, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When several humans share a session, an agent reading its own thread had no way to tell its participants apart — every human Message arrived as bare content. This retains the sender's name on human-authored Messages delivered to the owner of a Conversation, so the agent can attend to who is actually speaking.
deliveryTextnow prefixes a human's own-thread Message with aName:speaker label; an agent's own-thread Message still carries no label, and framing for relayed/opaque recipients is unchanged.ParticipantService.ensureHumanmaterializes a human who turned up on their own — a session owner or an open-session guest noinviteever added — as an idempotent, inert roster member in the orchestrator's home Conversation, so the actor behind their messages is a real, listable Participant.ensureHumanfor any human authorized to see the session before marking them present, so theconnectedtransition lands on a row that already exists. A restricted session's uninvited visitor is still not materialized.docs/server/conversations.md) updated to describe the new owner-delivery labelling.Screenshots
N/A — server-only behavior change.
How to test
pnpm --filter @tangent/server test— new coverage inconversationRouter.test.ts,participantService.test.ts, andchat.test.tsasserts the speaker label,ensureHumanidempotency, and join-time materialization/presence.Name:and replies to the right person.Notes
N/A