Fix overlay migration regressions - #1208
Open
tannerlinsley wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 5d2487d | Commit Preview URL Branch Preview URL |
Sep 01 2026, 03:37 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence
Merged PR #1205 left two user-visible overlay migration regressions in current main:
3state...instead of3s....DrawerHeaderalready renders a Radixh2, butCartDrawerpasses anotherh2as its title, producing invalid nested heading markup.The findings are recorded in unresolved review threads on #1205. Repeated title and body searches found no issue or PR owning these exact regressions. Open PR #1123 touches the cart as part of an older broad primitive migration, but it does not apply this current fix and is not an owner for the countdown regression.
Impact
Validation
pnpm testgit diff --checkRisk
Low. This changes two literal countdown suffixes and the inner cart title element from
h2tospan; the outer Radix title remains the accessibleh2.Source: #1205