Skip to content

Fix overlay migration regressions - #1208

Open
tannerlinsley wants to merge 1 commit into
mainfrom
agent/fix-overlay-migration-regressions
Open

Fix overlay migration regressions#1208
tannerlinsley wants to merge 1 commit into
mainfrom
agent/fix-overlay-migration-regressions

Conversation

@tannerlinsley

Copy link
Copy Markdown
Member

Evidence

Merged PR #1205 left two user-visible overlay migration regressions in current main:

  • Both deploy success dialogs render countdown text such as 3state... instead of 3s....
  • DrawerHeader already renders a Radix h2, but CartDrawer passes another h2 as its title, producing invalid nested heading markup.

The findings are recorded in unresolved review threads on #1205. Repeated title and body searches found no issue or PR owning these exact regressions. Open PR #1123 touches the cart as part of an older broad primitive migration, but it does not apply this current fix and is not an owner for the countdown regression.

Impact

  • Restores readable deploy redirect feedback.
  • Restores one valid accessible heading for the cart drawer.

Validation

  • pnpm test
  • TypeScript and type-aware lint pass.
  • 479 tests total, 478 passed, 1 environment-gated docs smoke test skipped.
  • git diff --check

Risk

Low. This changes two literal countdown suffixes and the inner cart title element from h2 to span; the outer Radix title remains the accessible h2.

Source: #1205

@tannerlinsley tannerlinsley added the source-audit Tracked by the automated source audit label Sep 1, 2026
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 5d2487d Commit Preview URL

Branch Preview URL
Sep 01 2026, 03:37 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

source-audit Tracked by the automated source audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant