Skip to content

fix: Prevent trailing slash in example paths #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Prevent trailing slash in example paths #1197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/routes/_library/$libraryId/$version.docs.framework.$framework.examples.$.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export const Route = createFileRoute(
throw notFound()
}

const examplePath = [framework, params._splat].join('/')
const examplePath = [framework, params._splat].filter(Boolean).join('/')
const defaultStartingPath = getExampleStartingPath(
framework,
params.libraryId,
Expand Down Expand Up @@ -349,7 +349,7 @@ function ExternalExamplePage({
throw notFound()
}

const examplePath = [frameworkId, _splat].join('/')
const examplePath = [frameworkId, _splat].filter(Boolean).join('/')

const mainExampleFile = getExampleStartingPath(frameworkId, libraryId)

Expand Down Expand Up @@ -610,7 +610,7 @@ function ClientExamplePage({
const { version, framework, _splat, libraryId } = Route.useParams()
const library = getLibrary(libraryId)
const branch = getBranch(library, version)
const examplePath = [framework, _splat].join('/')
const examplePath = [framework, _splat].filter(Boolean).join('/')
const githubUrl = `https://github.com/${library.repo}/tree/${branch}/examples/${examplePath}`
const initialFile = (
definition.initialFile ?? definition.workspace.entry
Expand Down
Loading